Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single-file-cli hangs even on domcontentloaded #43

Open
alex2awesome opened this issue Mar 9, 2023 · 2 comments
Open

single-file-cli hangs even on domcontentloaded #43

alex2awesome opened this issue Mar 9, 2023 · 2 comments

Comments

@alex2awesome
Copy link

Hello! I love single-file and single-file-cli. Truly the best option out there for saving full and complete webpages!

Right now, it's hitting this strange problem where, as far as I can tell, the page hangs indefinitely, even under the lowest load settings.

It might be related to this? puppeteer/puppeteer#9196 Not entirely sure.

To Reproduce
Run the following command in bash:

single-file --browser-executable-path=/opt/homebrew/bin/chromium https://web.archive.org/web/20140325112710/http://www.sfchronicle.com/ --block-images --dump-content --browser-headless false --browser-wait-until domcontentloaded --browser-debug

Environment

  • OS: MacOS
  • Browser: Chrome
@alex2awesome
Copy link
Author

My apologies... should have posted in https://github.com/gildas-lormeau/single-file-cli

I could not get it to work with playwright-chrome or playwright-firefox either.

However, if I manage playwright on my own and then integrate singleFile as in: https://github.com/gildas-lormeau/SingleFile/wiki/How-to-execute-a-user-script-before-a-page-is-saved, it does work

@gildas-lormeau
Copy link
Owner

Sorry for the very late reply, I confirm the issue you're describing is something I've already seen in the past. AFAIK, it's not related to the implementation of the single-file-cli.

I'm also transferring the issue ;)

@gildas-lormeau gildas-lormeau transferred this issue from gildas-lormeau/SingleFile Jul 23, 2023
@gildas-lormeau gildas-lormeau transferred this issue from gildas-lormeau/single-filez-cli Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants