Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission for assignment 4. #4

Open
giangbimin opened this issue Oct 4, 2023 · 1 comment
Open

Submission for assignment 4. #4

giangbimin opened this issue Oct 4, 2023 · 1 comment

Comments

@giangbimin
Copy link
Owner

Assignment - 1
Link Demo: Link demo
@giangbimin giangbimin changed the title Submission for assignment 4 Submission for assignment 4. Oct 4, 2023
@tienan92it
Copy link

Hello @giangbimin , solid work!. Below is some feedback for your assignment.

Requirements

  • All core functionalities present
  • Proper Tailwind implementation
  • Book detail page
  • 404 page
  • Redirect after deletion
  • Bonus: Tailwind dark/light mode
  • Bonus: URL state sync

Final result: 🔥 passed 100% of requirements

Feedback

  1. Book detail page is low contrast in dark mode.
Screenshot 2023-10-18 at 16 59 52

Cool! This project is clean and has a good structure. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tienan92it @giangbimin