Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission for assignment 1. #1

Open
giangbimin opened this issue Sep 18, 2023 · 1 comment
Open

Submission for assignment 1. #1

giangbimin opened this issue Sep 18, 2023 · 1 comment

Comments

@giangbimin
Copy link
Owner

giangbimin commented Sep 18, 2023

Assignment - 1
Link Demo: Link demo

@ngolapnguyen
Copy link

ngolapnguyen commented Sep 23, 2023

Requirements

  • Render correct table elements
  • Create book
  • Delete book
  • Search book by title
  • Semantic HTML
  • Standard use of CSS and JavaScript
  • Store data in LocalStorage

Final result: ✅ passed 70% of requirements

Feedbacks

Solid work 🤔 I don't think I have feedbacks for you at this stage. There are some bugs in the way we are handling local storage data though. Test these scenarios:

  1. Data gets cleared for no reason:
    1. Open the app (or reload to make sure we begin testing with initial data)
    2. Open the add book modal
    3. Don't fill anything. Hit Add. Close the alert
    4. Now fill the form and hit Add again
    5. Observe a new book is not added
    6. Reload the page, and observe that we end up with an empty table
  2. New book gets added incorrectly:
    1. Open the app
    2. Add a new book
    3. Open the add book modal again, but this time do not fill in anything
    4. Hit Add & close the alert
    5. Observe that a new book is still added (& the data seems to be from the previously added book at step 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants