Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't take testing.TB in cmd/gg tests #98

Open
zombiezen opened this issue Feb 7, 2019 · 0 comments
Open

Don't take testing.TB in cmd/gg tests #98

zombiezen opened this issue Feb 7, 2019 · 0 comments

Comments

@zombiezen
Copy link
Member

cmd/gg.newTestEnv takes in a testing.TB:

https://github.com/zombiezen/gg/blob/7a34fa369d22ac969419dd375a19c0ee031ebeec/cmd/gg/main_test.go#L138

It would be better to avoid doing this: if it needs to log, then it should take in a logging interface. However, it does do auto-skipping:

https://github.com/zombiezen/gg/blob/7a34fa369d22ac969419dd375a19c0ee031ebeec/cmd/gg/main_test.go#L142-L144

... which would be annoying to replicate across all test sites, but this is what internal/git does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zombiezen