Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #47

Closed
zombiezen opened this issue Jul 8, 2018 · 2 comments
Closed

Windows support #47

zombiezen opened this issue Jul 8, 2018 · 2 comments
Labels
enhancement New feature or request windows Windows-specific issue

Comments

@zombiezen
Copy link
Member

It would be nice to have Windows support. While I don't develop on Windows regularly, I feel confident enough in the test suite that if I start running Windows in CI (probably using AppVeyor) that it would work fairly well. Shipping Windows binaries would be easy at that point.
@zombiezen zombiezen added the enhancement New feature or request label Jul 8, 2018
@zombiezen zombiezen mentioned this issue Jul 8, 2018
Closed
zombiezen added a commit that referenced this issue Sep 5, 2020
@zombiezen
all: start Windows support
8a53c57 
Updates #47
@zombiezen
Copy link
Member Author

In the time since I opened this issue, I am now primarily developing on a Windows machine with WSL. How the times have changed. 😄

The test suite is mostly passing, but I'm stuck on getting the histedit tests to work because the Git editor doesn't seem to want to recognize Windows binaries or CMD built-ins.

zombiezen added a commit that referenced this issue Sep 7, 2020
@zombiezen
cmd/gg: use Git Bash for Windows editor shell command
ae48dc1 
Updates #47
zombiezen added a commit that referenced this issue Sep 7, 2020
@zombiezen
internal/escape: rename Shell to Bash
8cce7fd 
Because we're using Bash on all platforms, this means that we shouldn't
be doing a platform-dependent switch. Explicitly naming functions after
Bash helps make it clear that this is desired behavior.

Updates #47
zombiezen added a commit that referenced this issue Sep 7, 2020
@zombiezen
.github/workflows: build Windows binary
f382b32 
Updates #47
@zombiezen zombiezen added the windows Windows-specific issue label Sep 7, 2020
@zombiezen
Copy link
Member Author

Test suite passes now. There is another small issue with SSH, but not release-blocking: #120.

Marking as fixed, but we still need packaging: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request windows Windows-specific issue
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zombiezen