-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WGSL: Support the pointer_composite_access
language extension
#6192
Comments
pointer_composite_access
language extension
pointer_composite_access
language extensionpointer_composite_access
language extension
@rcoreilly: Basic support for parsing |
I am working on this. |
@sagudev: Sweet! I'll plan on reviewing your PRs. It might be next year when I have bandwidth to do so, but I think it's the same for all the Firefox WebGPU/Naga team. 😅 |
It would be nice to get #6814 landed before (holidays). |
I think we need to remove all usages of wgpu/naga/src/front/wgsl/lower/mod.rs Line 1981 in ee3ae0e
Also I think some types of expressions are already supported, so It would be really interesting to see CTS results with pointer_composite_access reported as supported but otherwise unimpl. |
Description
The WGSL spec has a
requires
directive to request language extensions, such aspointer_composite_access
https://www.w3.org/TR/WGSL/#language-extensions-secWhen I put that at the top of my .wgsl shader, it barfs:
I would particularly be interested in when that specific language extension
pointer_composite_access
will be included as well -- huge improvement in usability. Alsounrestricted_pointer_parameters
seems rather important if I understand it properly, which I'm not sure I do..Repro steps
add that line to the top of any .wgsl code.
Expected vs observed behavior
didn't work.
Platform
Mac OS, latest trunk HEAD 26398ea using
naga
cli, and v0.19.4.1 of wgpu-native.The text was updated successfully, but these errors were encountered: