Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone victory until battle sequences resolve #5

Open
jaythomas opened this issue Mar 5, 2018 · 0 comments
Open

Postpone victory until battle sequences resolve #5

jaythomas opened this issue Mar 5, 2018 · 0 comments
Labels

Comments

@jaythomas
Copy link
Member

It makes no sense to flag a winner when a move is still being resolved.

game.play('player1', [getCard('grab'), getCard('cheap-shot')])
Dark rolls the bones to determine Jay's fate... 5 damage!
Jay discards Gut Punch (-2), Gut Punch (-2).
Jay has died.
Dark wins!
Jay grabs Dark. Respond or pass, Dark.
valid counters: [ 'insurance - 0' ]
Jay takes a cheap shot at Dark.

This would mean someone could die after being announced winner, when such a situation would be considered a draw by the Junkyard Brawl edition of the rules. Moreover, details on resolving moves and game winners needs to be documented in the rules in the README.

@jaythomas jaythomas added the bug label Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant