-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call stacks containing <anonymous> source fail to symbolicate #1580
Comments
Hi, Symbolicator is currently set up in such a way that you can't send it frames which it will definitely not be able to process. JS frames without an |
@loewenheim It's technically possible to pre-process the stack traces in my case (using Electron). In other cases though, browser crash reports (getsentry/sentry#38940) are sent directly from the browser without a chance to process them before reaching sentry/relay servers. I pulled down symbolicator locally and made the necessary changes for this as well #1581 |
Right, that sounds like a good enough reason to do this. |
Environment
macOS 15.2 ARM64
Steps to Reproduce
/symbolicate-js
endpointExpected Result
The call stack is returned with a partially symbolicated call stack.
Actual Result
Additional Background
I'm investigating collecting unresponsive renderer call stacks in Sentry using the new Crash Reporting API. This relates to the work @timfish initiated in getsentry/sentry-javascript#14044
The first line of the call stacks contain the
<anonymous>
source. Whether this is expected or not, it'd be great if the symbolicator service could handle this case so the call stacks can be symbolicated.I found the code within V8 which handles formatting JS call stacks.
https://source.chromium.org/chromium/chromium/src/+/main:v8/src/objects/call-site-info.cc;l=688-718;drc=763100e0bf9a25ba6f203612af5a4331fbd2d048
According to the implementation of
AppendFileLocation
, it can output<anonymous>
by itself if there's no line number associated with the frame.The text was updated successfully, but these errors were encountered: