From 39b7d732947b6a7de8d7f183b2d70fef158ed697 Mon Sep 17 00:00:00 2001 From: Evan Purkhiser Date: Thu, 21 Nov 2024 13:31:21 -0500 Subject: [PATCH] feat(uptime): Rename "Allow {Tracing->Sampling}" --- .../app/views/alerts/rules/uptime/uptimeAlertForm.spec.tsx | 6 +++--- static/app/views/alerts/rules/uptime/uptimeAlertForm.tsx | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/static/app/views/alerts/rules/uptime/uptimeAlertForm.spec.tsx b/static/app/views/alerts/rules/uptime/uptimeAlertForm.spec.tsx index 8f6f8e42c9f45b..9d8979b96d8026 100644 --- a/static/app/views/alerts/rules/uptime/uptimeAlertForm.spec.tsx +++ b/static/app/views/alerts/rules/uptime/uptimeAlertForm.spec.tsx @@ -54,7 +54,7 @@ describe('Uptime Alert Form', function () { await userEvent.type(input('Name of header 1'), 'X-Something'); await userEvent.type(input('Value of X-Something'), 'Header Value'); - await userEvent.click(screen.getByRole('checkbox', {name: 'Allow Tracing'})); + await userEvent.click(screen.getByRole('checkbox', {name: 'Allow Sampling'})); const name = input('Uptime rule name'); await userEvent.clear(name); @@ -119,7 +119,7 @@ describe('Uptime Alert Form', function () { expect(screen.getByRole('menuitemradio', {name: 'POST'})).toBeChecked(); await selectEvent.openMenu(input('Environment')); expect(screen.getByRole('menuitemradio', {name: 'prod'})).toBeChecked(); - expect(screen.getByRole('checkbox', {name: 'Allow Tracing'})).toBeChecked(); + expect(screen.getByRole('checkbox', {name: 'Allow Sampling'})).toBeChecked(); }); it('handles simple edits', async function () { @@ -194,7 +194,7 @@ describe('Uptime Alert Form', function () { await userEvent.type(input('Name of header 2'), 'X-Another'); await userEvent.type(input('Value of X-Another'), 'Second Value'); - await userEvent.click(screen.getByRole('checkbox', {name: 'Allow Tracing'})); + await userEvent.click(screen.getByRole('checkbox', {name: 'Allow Sampling'})); const name = input('Uptime rule name'); await userEvent.clear(name); diff --git a/static/app/views/alerts/rules/uptime/uptimeAlertForm.tsx b/static/app/views/alerts/rules/uptime/uptimeAlertForm.tsx index 13f0daf779e7ab..ff027dd97315c9 100644 --- a/static/app/views/alerts/rules/uptime/uptimeAlertForm.tsx +++ b/static/app/views/alerts/rules/uptime/uptimeAlertForm.tsx @@ -220,7 +220,7 @@ export function UptimeAlertForm({project, handleDelete, rule}: Props) { />