Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare Relay unhealthy when a service panics #4037

Open
jjbayer opened this issue Sep 16, 2024 · 0 comments
Open

Declare Relay unhealthy when a service panics #4037

jjbayer opened this issue Sep 16, 2024 · 0 comments
Assignees

Comments

@jjbayer
Copy link
Member

jjbayer commented Sep 16, 2024

Following decision of internal meeting:

When a panic escapes a service loop, mark Relay's state as unhealthy such that the outside orchestrator can cut off traffic to this instance, spin up more instances and / or kill the instance.

Possible implementations:

  1. Introduce join handles and let the main task flip the health state to unhealthy once a join handle returns with a panic.
  2. Force every service implementation to report a health state, report overall unhealthy as soon as a single service reports unhealthy (OR condiditon
  3. ... ?

ref: INC-875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant