Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: date type values are displayed as int type #5577

Closed

Conversation

iwakiriK
Copy link
Contributor

@iwakiriK iwakiriK commented Aug 31, 2021

What type of PR is this? (check all applicable)

  • Bug Fix

Description

For values of date type, if moment.utc() is executed and columnType is string, it will be displayed as int type.

image

This PR will fix this problem.

Related Tickets & Documents

https://momentjs.com/docs/#/parsing/utc/

@guidopetri
Copy link
Contributor

@iwakiriK , thanks for the PR! Same story here, we've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #5577 (e7861bf) into master (9751678) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5577   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         154      154           
  Lines       12624    12624           
  Branches     1716     1716           
=======================================
  Hits         7663     7663           
  Misses       4735     4735           
  Partials      226      226           

@justinclift
Copy link
Member

Looks like it's failing our frontend lint tests. 😦

@eradman
Copy link
Collaborator

eradman commented Sep 5, 2023

@iwakiriK can you illustrate the problem this PR solves using a simpler query?

Datetimes are interpreted correctly on 10.1.0 (which uses numeral.js) and 23.09.0-dev (which uses numbro.js)

datetime

@eradman eradman self-requested a review September 5, 2023 13:54
@eradman
Copy link
Collaborator

eradman commented Jul 30, 2024

Re-tested this with 24.07.0-dev and have not observed a problem. Closing, but feel free to re-open with more information

@eradman eradman closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants