Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed sms code #3913

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Removed sms code #3913

merged 1 commit into from
Jun 10, 2020

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jun 9, 2020

Closes #2934

What has been done to verify that this works as intended?

I ran all tests we have and everything seems fine.

Why is this the best possible solution? Were any other approaches considered?

We can't use sms in automated way due to Google policy so we decided to get rid of the unused code.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010
Copy link
Member Author

grzesiek2010 commented Jun 9, 2020

I had been waiting long and I think now it's a good time, we don't have big pull requests which we would need to update, so it would be good to merge this pr as soon as possible.

Copy link
Member

@seadowg seadowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm going to hold off on merging this to let #3772 get through without any potential conflicts

@lognaturel lognaturel merged commit d8c7c09 into getodk:master Jun 10, 2020
@lognaturel
Copy link
Member

So sad we have to do this but so it goes. Thanks for doing the dirty work, @grzesiek2010.

@seadowg, no major conflicts with #3772 so let's get it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out a way to enable SMS or remove all SMS code by September 2019
3 participants