Show Central version in modal #1099
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sadiqkhoja
reviewed
Dec 16, 2024
src/request-data/resources.js
Outdated
| const result = typeof data === 'object' && data != null | ||
| ? mergeDeepLeft(data, configDefaults) | ||
| : configDefaults; | ||
| result.currentDate = new Date(headers.get('date')); |
There was a problem hiding this comment.
I wanted to keep currentDate somewhat current. May be later on we can update this variable (or move to a provide/inject) whenever there is any API response from the backend.
There was a problem hiding this comment.
I like that idea! I think I could fit that in this PR pretty easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#849.
What has been done to verify that this works as intended?
I've tried it out locally. However, this is a draft PR, and I haven't added tests yet.
Why is this the best possible solution? Were any other approaches considered?
Once we're ready for code review, I'll add comments about individual lines.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes