From 008ae1c93e2f9ec13fa202a0d08061633980b9de Mon Sep 17 00:00:00 2001 From: Clint Tseng Date: Thu, 1 Nov 2018 16:34:33 -0700 Subject: [PATCH 1/5] styles: adjust a bunch of input-focus styles to be cleaner. --- lib/components/app.vue | 15 +++++++++++++++ lib/components/navbar.vue | 7 +++++++ 2 files changed, 22 insertions(+) diff --git a/lib/components/app.vue b/lib/components/app.vue index 855fda807..faf8b94d9 100644 --- a/lib/components/app.vue +++ b/lib/components/app.vue @@ -148,6 +148,11 @@ h1 { margin-bottom: 3px; } +a:focus { + background-color: transparentize(#000, 0.94); + outline: none; +} + .text-muted { color: $color-text-muted; } @@ -209,6 +214,11 @@ a:hover, a:focus { overflow: hidden; padding: 6px 10px 5px; position: relative; + + &:focus { + box-shadow: 0 0 0 3px rgba(0, 0, 0, 0.18); + outline: none; + } } .btn-primary { @@ -469,6 +479,11 @@ a:hover, a:focus { &:hover { border-bottom-color: $color-accent-primary; } + + &:focus { + border-bottom-color: $color-action-foreground; + outline: none; + } } &.active > a { diff --git a/lib/components/navbar.vue b/lib/components/navbar.vue index 55b8f2f74..8a2dc0cf2 100644 --- a/lib/components/navbar.vue +++ b/lib/components/navbar.vue @@ -191,6 +191,13 @@ $shadow-color: #dedede; border-top-color: transparentize(#fff, 0.3); transition-duration: 0s; } + + &:focus { + border-top-color: transparentize(#fff, 0.15); + box-shadow: 0 3px 0 transparentize(#000, 0.9); + outline: none; + transition-duration: 0s; + } } .active > a, .open > a { From 11301ae96730719b409234c3497e987db6617491 Mon Sep 17 00:00:00 2001 From: Clint Tseng Date: Thu, 1 Nov 2018 16:35:01 -0700 Subject: [PATCH 2/5] styles: increase button-icon and panel-body padding. --- lib/components/app.vue | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/components/app.vue b/lib/components/app.vue index faf8b94d9..5de253b05 100644 --- a/lib/components/app.vue +++ b/lib/components/app.vue @@ -205,6 +205,10 @@ a:hover, a:focus { [class^="icon-"], [class*=" icon-"] { vertical-align: -1px; + + .btn & { + margin-right: 3px; + } } .btn { @@ -432,7 +436,7 @@ a:hover, a:focus { } .panel-body { - padding: $padding-top-table-data $padding-right-table-data + padding: 14px $padding-right-table-data $padding-bottom-table-data $padding-left-table-data; hr { From 98077a7a2022700d146fbfe584f10fcd007ca82b Mon Sep 17 00:00:00 2001 From: Clint Tseng Date: Thu, 1 Nov 2018 16:35:23 -0700 Subject: [PATCH 3/5] styles: adjust new-form dropzone styling; make chosen file separate. --- lib/components/form/new.vue | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/components/form/new.vue b/lib/components/form/new.vue index d18e08ded..ce38cd75a 100644 --- a/lib/components/form/new.vue +++ b/lib/components/form/new.vue @@ -168,11 +168,13 @@ export default { From 0f6f2aedf4b7a66789da427acdac45d8373614cd Mon Sep 17 00:00:00 2001 From: Clint Tseng Date: Thu, 1 Nov 2018 16:36:04 -0700 Subject: [PATCH 4/5] style: minor adjustments to submissions table row#, loading styles. * align row# with text baseline of the rest of the table. * move the loading message to align left. darken and center icon/text. --- lib/components/form/submission/list.vue | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/components/form/submission/list.vue b/lib/components/form/submission/list.vue index ca7d09718..25115377d 100644 --- a/lib/components/form/submission/list.vue +++ b/lib/components/form/submission/list.vue @@ -342,6 +342,7 @@ export default { // Adding min-width so that the table's width does not increase as the row // numbers increase. min-width: 42px; + padding-top: 11px; text-align: right; vertical-align: middle; } @@ -456,18 +457,22 @@ export default { } #form-submission-list-message { - margin: 0 auto 20px; + margin-left: 28px; + padding-bottom: 38px; position: relative; - width: 375px; #form-submission-list-spinner-container { + float: left; + margin-right: 8px; position: absolute; - top: 9px; + top: 8px; + width: 16px; // TODO: eventually probably better not to default spinner to center. } #form-submission-list-message-text { - color: $color-text-muted; - margin-left: 20px; + color: #555; + font-size: 12px; + padding-left: 24px; } } From baa94ae23e57a72454170fea8ea8b7ea8c8d6635 Mon Sep 17 00:00:00 2001 From: Matthew White Date: Thu, 1 Nov 2018 20:13:19 -0400 Subject: [PATCH 5/5] Add space between icon and text within links --- lib/components/app.vue | 2 +- lib/components/form/attachment/upload-files.vue | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/components/app.vue b/lib/components/app.vue index 5de253b05..ce6549647 100644 --- a/lib/components/app.vue +++ b/lib/components/app.vue @@ -206,7 +206,7 @@ a:hover, a:focus { [class^="icon-"], [class*=" icon-"] { vertical-align: -1px; - .btn & { + .btn &, a & { margin-right: 3px; } } diff --git a/lib/components/form/attachment/upload-files.vue b/lib/components/form/attachment/upload-files.vue index 59bd8832a..7b9436783 100644 --- a/lib/components/form/attachment/upload-files.vue +++ b/lib/components/form/attachment/upload-files.vue @@ -64,9 +64,3 @@ export default { } }; - -