-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip find_package
for already present targets
#236
base: main
Are you sure you want to change the base?
Conversation
@GregTheMadMonk , thanks for the initiative. Let me know when this is finished (it appears that this is still a draft). |
I would be appreciate if the same support is provided to toml format for better CMake/CPM intergration. if (REFLECTCPP_TOML)
list(APPEND REFLECT_CPP_SOURCES
src/reflectcpp_toml.cpp
)
if (TARGET tomlplusplus::tomlplusplus)
target_link_libraries(reflectcpp PRIVATE tomlplusplus::tomlplusplus)
else()
if (MSVC)
target_link_libraries(reflectcpp PRIVATE "${VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/lib/tomlplusplus${CMAKE_STATIC_LIBRARY_SUFFIX}")
else ()
target_link_libraries(reflectcpp PRIVATE "${VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/lib/libtomlplusplus${CMAKE_STATIC_LIBRARY_SUFFIX}")
endif ()
endif()
endif() |
@GregTheMadMonk , what is status on this PR? It is still marked as a draft...is that on purpose? Do you want me to review and then potentially merge it? |
Draft, not implemented for msgpack-c and PkgConfig
02c344b
to
00abc7b
Compare
@liuzicheng1987 yes, sorry, I was sidetracked by other tasks and kind of pushed this to the side. Here I've rebased the branch to match your current
Additionally, I've made it so that IDK if I should mark it as a regular PR or leave it a draft for now. It'd be great if someone else tested and verified that it doesn't break builds for them too. edit: Removed the "Draft" mark, since I don't think there's anything else to add here except maybe get msgpack working and at least have someone else verify it works for them too. |
For #231.
Didn't properly test yet, and I don't know what to do with
msgpack-c
andPkgConfig
, if anything needs to be done for them