Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] "select all" button is not working correctly when filters are applied #335

Open
hkalexling opened this issue Sep 3, 2022 · 0 comments · May be fixed by #337
Open

[Bug Report] "select all" button is not working correctly when filters are applied #335

hkalexling opened this issue Sep 3, 2022 · 0 comments · May be fixed by #337
Labels
bug Something isn't working

Comments

@hkalexling
Copy link
Member

Describe the bug

The "select all" button doesn't work as expected when there are filters applied

To Reproduce
Steps to reproduce the behavior:

  1. Search through a plugin and list some chapters
  2. Apply some filters to reduce the number of chapters in the table
  3. Click "Select all"
  4. Click "Download selected". Notice that the confirmation box says "Download x selected chapters", where x is larger than the number of chapters in the table

Expected behavior

The number of chapters selected with the "Select all" button should match the number of chapters in the table

Environment (please complete the following information):

  • OS: Ubuntu 20.04
  • Browser: Version 104.0.5112.79 (Official Build) Arch Linux (64-bit)
  • Mango Version: v0.27.0
@hkalexling hkalexling added the bug Something isn't working label Sep 3, 2022
hkalexling added a commit that referenced this issue Sep 9, 2022
@hkalexling
Restrict table selection to id seletable
6f39c2a 
fixes #335
@hkalexling hkalexling linked a pull request Sep 9, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.27.1 getmango/Mango
1 participant
@hkalexling