From 5c6bd8d49e69b5efc6d2543bd9d1b0daacd97399 Mon Sep 17 00:00:00 2001
From: Andrei <92177534+andrei-21@users.noreply.github.com>
Date: Sat, 30 Dec 2023 09:52:41 +0000
Subject: [PATCH] Upload bindings files once (#837)

(cherry picked from commit 203c72638463030b26d20caaab532b26352a37ed)
---
 .github/workflows/deploy-release.yml | 54 ++++++++++++----------------
 1 file changed, 23 insertions(+), 31 deletions(-)

diff --git a/.github/workflows/deploy-release.yml b/.github/workflows/deploy-release.yml
index b4c09dee..55a07ced 100644
--- a/.github/workflows/deploy-release.yml
+++ b/.github/workflows/deploy-release.yml
@@ -46,20 +46,16 @@ jobs:
           command: build
           args: --release --target ${{ matrix.target }}
       - name: Upload library binaries
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v4
         with:
           path: target/${{ matrix.target }}/release/libuniffi_lipalightninglib.a
           name: build-${{ matrix.target }}
-      - name: Upload header file
-        uses: actions/upload-artifact@master
+      - name: Upload bindings files
+        uses: actions/upload-artifact@v4
+        if: ${{ matrix.target == 'x86_64-apple-ios' }}
         with:
-          path: bindings/swift/lipalightninglibFFI.h
-          name: header-file
-      - name: Upload bindings file
-        uses: actions/upload-artifact@master
-        with:
-          path: bindings/swift/lipalightninglib.swift
-          name: bindings-file-ios
+          path: bindings/swift/lipalightninglib*
+          name: bindings-files-ios
 
   cross-compile-android:
     name: cross-compile-android
@@ -96,12 +92,13 @@ jobs:
           command: build
           args: --release --target ${{ matrix.target }}
       - name: Upload library binaries
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v4
         with:
           path: target/${{ matrix.target }}/release/libuniffi_lipalightninglib.so
           name: build-${{ matrix.target }}
       - name: Upload bindings file
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v4
+        if: ${{ matrix.target == 'aarch64-linux-android' }}
         with:
           path: bindings/kotlin/uniffi/lipalightninglib/lipalightninglib.kt
           name: bindings-file-android
@@ -112,17 +109,17 @@ jobs:
     runs-on: macos-latest
     steps:
       - name: Download x86 bin
-        uses: actions/download-artifact@master
+        uses: actions/download-artifact@v4
         with:
           path: target/x86_64-apple-ios/release
           name: build-x86_64-apple-ios
       - name: Download aarch64 bin
-        uses: actions/download-artifact@master
+        uses: actions/download-artifact@v4
         with:
           path: target/aarch64-apple-ios/release
           name: build-aarch64-apple-ios
       - name: Download aarch64sim bin
-        uses: actions/download-artifact@master
+        uses: actions/download-artifact@v4
         with:
           path: target/aarch64-apple-ios-sim/release
           name: build-aarch64-apple-ios-sim
@@ -133,7 +130,7 @@ jobs:
             target/aarch64-apple-ios-sim/release/libuniffi_lipalightninglib.a \
             target/x86_64-apple-ios/release/libuniffi_lipalightninglib.a
       - name: Upload universal binary
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v4
         with:
           path: target/universal/release/libuniffi_lipalightninglib_simulator.a
           name: build-ios-simulator-universal
@@ -165,25 +162,20 @@ jobs:
           git_user_signingkey: true
           git_commit_gpgsign: true
       - name: Download aarch64 bin
-        uses: actions/download-artifact@master
+        uses: actions/download-artifact@v4
         with:
           path: target/aarch64-apple-ios/release
           name: build-aarch64-apple-ios
       - name: Download simulator universal bin
-        uses: actions/download-artifact@master
+        uses: actions/download-artifact@v4
         with:
           path: target/universal/release
           name: build-ios-simulator-universal
-      - name: Download header file
-        uses: actions/download-artifact@master
-        with:
-          path: bindings/swift/
-          name: header-file
-      - name: Download bindings file
-        uses: actions/download-artifact@master
+      - name: Download bindings files
+        uses: actions/download-artifact@v4
         with:
           path: bindings/swift/
-          name: bindings-file-ios
+          name: bindings-files-ios
       - name: Create xcframework
         run: |
           git clone git@github.com:getlipa/lipa-lightning-lib-swift.git
@@ -194,7 +186,7 @@ jobs:
           cd lipa-lightning-lib-swift
           zip -9 -r lipalightninglibFFI.xcframework.zip lipalightninglibFFI.xcframework
       - name: Upload xcframework zip
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v4
         with:
           path: lipa-lightning-lib-swift/lipalightninglibFFI.xcframework.zip
           name: lipalightninglibFFI.xcframework
@@ -268,22 +260,22 @@ jobs:
           git_user_signingkey: true
           git_commit_gpgsign: true
       - name: Download aarch64 bin
-        uses: actions/download-artifact@master
+        uses: actions/download-artifact@v4
         with:
           path: target/aarch64-linux-android/release
           name: build-aarch64-linux-android
       - name: Download armv7 bin
-        uses: actions/download-artifact@master
+        uses: actions/download-artifact@v4
         with:
           path: target/armv7-linux-androideabi/release
           name: build-armv7-linux-androideabi
       - name: Download i686 bin
-        uses: actions/download-artifact@master
+        uses: actions/download-artifact@v4
         with:
           path: target/i686-linux-android/release
           name: build-i686-linux-android
       - name: Download bindings file
-        uses: actions/download-artifact@master
+        uses: actions/download-artifact@v4
         with:
           path: bindings/kotlin/uniffi/lipalightninglib
           name: bindings-file-android