Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social share menu #130

Open
atavism opened this issue Jun 15, 2015 · 7 comments
Open

Add social share menu #130

atavism opened this issue Jun 15, 2015 · 7 comments
Assignees
Labels
Milestone

Comments

@atavism
Copy link

atavism commented Jun 15, 2015

Possibly with WeChat, Weibo, and Qzone buttons?

@atavism atavism added the P2 label Jun 15, 2015
@atavism atavism added this to the 0.0.6 milestone Jun 15, 2015
@atavism atavism added P1 and removed P2 labels Jun 16, 2015
@atavism atavism self-assigned this Jun 18, 2015
@atavism
Copy link
Author

atavism commented Jun 21, 2015

I added a share button to the side menu as that seems like the best location for it:

image

When you click on this button, you have the option to share a link to download FireTweet to a bunch of different apps using the standard share intent (see Weibo and WeChat among the list which I have installed). I'm trying to figure out how to customize this list; it's unfortunate FireTweet itself appears. If we only want to allow sharing to certain apps, I think we have to create our own list view instead according to https://clickclickclack.wordpress.com/2012/01/03/intercepting-androids-action_send-intents/#

image

@atavism
Copy link
Author

atavism commented Jun 25, 2015

Hey @Derekf5 and @myleshorton, what do you think about showing all the apps it's possible for the user to share to (above which is already implemented) vs. only being able to share to a predetermined set of apps (i.e. Weibo, WeChat, etc. for Chinese users)? The latter requires a custom solution, but it's doable.

@atavism
Copy link
Author

atavism commented Jun 25, 2015

Also, @Derekf5, do we have specific text we want to use here? Probably something similar to the autotweet, but I think we want to also include the direct download link, right?

@myleshorton
Copy link
Contributor

I think the latter is a significant improvement actually @atavism.

On Thu, Jun 25, 2015 at 11:54 AM, atavism [email protected] wrote:

Also, @Derekf5 https://github.com/Derekf5, do we have specific text we
want to use here? Probably something similar to the autotweet, but I think
we want to also include the direct download link, right?


Reply to this email directly or view it on GitHub
#130 (comment)
.

President
Brave New Software Project, Inc.
https://www.getlantern.org
pgp A998 2B6E EF1C 373E 723F A813 045D A255 901A FD89

@Derekf5
Copy link

Derekf5 commented Jun 25, 2015

@atavism text to go where? do you mean the text that users could share on various networks?

@atavism
Copy link
Author

atavism commented Jun 25, 2015

@Derekf5 Yeah, what do we want the share message to say?

@Derekf5
Copy link

Derekf5 commented Jun 25, 2015

@atavism I think it can be pretty similar to the auto tweet.

"Check out FireTweet. A Twitter app for Android that allows for unblocked tweeting anywhere in the world! Link"

how does that sound? We will obviously need to translate that text.

@getlantern getlantern deleted a comment from fffw Mar 1, 2021
@getlantern getlantern deleted a comment from Derekf5 Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants