Avoid discarding content changes on upload #6909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 17, 2025
distantnative
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Worked well in my tests, but it would be great if @afbora could get his skilled testing hands on this as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A file upload caused a loss of content changes. This is now avoided by merging the latest changes in the content.js module. With this fix, we can also fix another issue with file uploads in blocks and layouts by bringing back the onInput emitter in the files field from v4. This has been removed in one of the last releases to fix a collision with unsaved changes.
Related sandbox setup getkirby/sandbox#13
Changelog
Fixes
For review team