Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending section: prevent duplicate mixin #6915

Open
wants to merge 1 commit into
base: develop-minor
Choose a base branch
from

Conversation

distantnative
Copy link
Member

Description

Summary of changes

  • Our model sections now also use the section mixin.
  • For plugin components, when resolving mixin names to actual mixins, we check now if the component is extending a parent component. And if so, if that parent already included the mixin.

Reasoning

  • All plugin sections get the section mixin automatically injected. Our core sections should deal with the same.
  • When a section like pages section got extended so far, the section mixin was force injected and overwrote the load method from the parent (pages section).

Additional context

Marked for 4.7.0 to have sufficient time for testing and not needing to rush merging for 4.6.0 - if it can be tested before, no objections against including it already in 4.6.0.

Changelog

Fixes

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 4.7.0 milestone Jan 17, 2025
@distantnative distantnative self-assigned this Jan 17, 2025
@distantnative distantnative linked an issue Jan 17, 2025 that may be closed by this pull request
@distantnative distantnative requested a review from a team January 17, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Section extension: extending core sections doesn't work
1 participant