Option to get taxonomies of all descendant pages #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. What's the differences between your PR and this one. |
|
I haven't seen the one. His PR is very similar to mine, but his will make the changes to the existing function with additional parameters. Mine is another whole function. His is recursive, it loops through the pages, mine gets the pages directly via Grav, similar to the descendants collection. I'm not very familiar with PHP, so I don't know which method is better. But either way, I think this or his PR should be merged, since it adds an important functionality to Grav. |
|
I’m on vacation this week but will look at this and the other PR when I’m back. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to not only get the taxonomies of the children of a page, but also to get it from all descendants. This makes it possible to use the taxonomy list plugin on complex blog pages too.
To use it, just replace
taxonomylist.getChildPagesTags()withtaxonomylist.getDescendantPagesTags(), and you should get taxonomies of all descendant pages.closes #42
closes #35