Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete Additional URLs form #71

Open
petira opened this issue Mar 3, 2020 · 2 comments
Open

Cannot delete Additional URLs form #71

petira opened this issue Mar 3, 2020 · 2 comments
Labels

Comments

@petira
Copy link

petira commented Mar 3, 2020

Cannot delete Additional URLs form when it remains last. It reappears after saving.

Grav v1.6.21 - Admin v1.9.12 - Sitemap v1.9.4

@marknokes
Copy link

marknokes commented Mar 11, 2020

Same here. It adds a bad entry to the sitemap. I hacked the plugin's sitemap.php, beginning line 109 to check for location and lastmod before adding to $this->sitemap[]

foreach ($additions as $addition) {
            $entry = new SitemapEntry();
            $entry->location = $rootUrl . $addition['location'];
            $entry->lastmod = $addition['lastmod'];

            // New check
            if($addition['location'] && $addition['lastmod'])
            {
                $this->sitemap[] = $entry;
            }
            // End new check
        }

@rhukster rhukster added the bug label Jul 1, 2020
@Karmalakas
Copy link

Might be related maybe?
getgrav/grav-plugin-admin#2056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants