-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hangs with Jest run #7
Comments
@dennismphil Thanks for reporting,
Tests are hanged on |
I have tried debugging this issue and found out that it takes a lot of time to generate Could not find any reason why it takes more time with jest. |
Did some more debugging and found out that, The . GifEncoder packages tries to learn the color palate for every frame and alter them accordingly. Which is taking a lot of time with jest. |
Any updates on this one please? |
Not yet, we have been busy with other things. It might be some time till we get to this, since we have our hands full at the moment. That said, we would appreciate any help, and would gladly accept Pull Requests! |
Got a chance to debug this more. Yes, this completed after a really really really long time. Eg: 47 frames; device height=1250; device width: 1200; => takes a long time and finally completes. The encoder SuggestionShort term fixskip few frames (eg use a logarithmic scale for Long term fix:Consider switching to a more efficient encoder. |
The thing with skipping frames is that the plugin has no way of telling if it's skipping an important frame. gif-encoder-2 claims some improvements, and at first glance it looks like a drop-in replacement. That being said, I wonder why would this bother only jest, and not other runners. |
Any reason why it emits a gif and not an m4v or something like that? My understanding is those are more compact and efficient (could be wrong though!) |
gif, primarily because it is html/browser friendly. but one could argue that modern browsers allow videos to be embedded too. Perhaps we can have it configurable. Really depends on what works best for users. We do not use this much :P |
Any modern browsers should be able to handle video files just fine, adding the good things that you can control the progress bar and play/pause |
That is true. Anybody interested in taking a stab at this? I believe it shouldn't be too hard to wire up something like ffmpeg and dump the output as a movie? |
When I attempted to integrate this with Jest using
TAIKO_PLUGIN=screencast jest
it seemed to hang.This is a very useful and powerful feature, especially during test runs headlessly.
Thank you for the hard work and the beautiful API ❤️
The text was updated successfully, but these errors were encountered: