Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 1.3.0 default WMS version #455

Open
PedroVenancio opened this issue Aug 17, 2023 · 0 comments
Open

Make 1.3.0 default WMS version #455

PedroVenancio opened this issue Aug 17, 2023 · 0 comments
Labels

Comments

@PedroVenancio
Copy link

This issue #248 and PR #307 had pretended to change the default WMS version to 1.3.0, but I believe it still needs some improvement, because version 1.1.1 is still hardcoded in some places:

https://github.com/search?q=repo%3Ageopython%2FGeoHealthCheck%201.1.1&type=code

Also, changing from 1.1.1 to 1.3.0 implies some differences, for instance:

  • From SRS to CRS;
  • BBOX from xmin,ymin,xmax,ymax to ymin,xmin,ymax,xmax

I've tried to change locally all default 1.1.1 to 1.3.0, but WMS Drilldown keeps using version=1.1.1, and I could not find why.

At this time I think 1.3.0 should be the default for all tests of GHC, and it seems it is not, even after #307.

Context (please complete the following information):

  • GeoHealthCheck Version 0.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant