Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapfish-print-v2 update to 2.3.2 release #8490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jodygarnett
Copy link
Contributor

See recent release notes:

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74 josegar74 added this to the 4.4.7 milestone Nov 7, 2024
@josegar74 josegar74 marked this pull request as draft November 7, 2024 08:25
Copy link

sonarcloud bot commented Nov 7, 2024

@josegar74
Copy link
Member

josegar74 commented Nov 7, 2024

@jodygarnett I've committed updates to the Mapfish configuration file, that were preventing to start up GeoNetwork.

I'm not sure if the configuration has change in the new version, or if it was wrong in GeoNetwork and the parser in the previous Mapfish versions was less strict (most probably related to this).

With the changes, trying to print a map, I get this an unclear error in the log:

[WARNING] /geonetwork/pdf/create.json
java.lang.NullPointerException
    at org.mapfish.print.servlet.MapPrinterServlet.createPDF (MapPrinterServlet.java:204)
    at org.mapfish.print.servlet.MapPrinterServlet.doPost (MapPrinterServlet.java:119)
    at javax.servlet.http.HttpServlet.service (HttpServlet.java:707)
    at javax.servlet.http.HttpServlet.service (HttpServlet.java:790)

Printing the base map works fine, but adding a WMS layer (for example, from the ISO19139 samples), fails with the previous error.

@jodygarnett jodygarnett marked this pull request as ready for review November 8, 2024 04:22
@jodygarnett
Copy link
Contributor Author

The yaml parser changed, the new parser required a space between key / value in yaml document.

@josegar74
Copy link
Member

The yaml parser changed, the new parser required a space between key / value in yaml document.

@jodygarnett this is solved in c171775, but it seems having problems printing the map with a WMS layer (for example, from the ISO19139 samples). Can you check it?

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants