Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata editor / Fix display of multiple choice elements with custom label #8479

Merged

Conversation

josegar74
Copy link
Member

Elements that define a btnLabel value and define multiple choices, like:

<element name="gmd:DQ_Result" id="128">
    <label>Ergebnis</label>
    <btnLabel>Ergebnis</btnLabel>
...
</element>

Are displayed with a wrong font due to FontAwesome styling applied wrongly to button elements:

button-font-1

After the fix:

button-font-2

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74 josegar74 added this to the 4.4.7 milestone Oct 30, 2024
@fxprunayre fxprunayre merged commit 6dbaa47 into geonetwork:main Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants