Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align source layer implementation with QGIS #174

Open
gjmooney opened this issue Oct 7, 2024 · 0 comments
Open

Align source layer implementation with QGIS #174

gjmooney opened this issue Oct 7, 2024 · 0 comments

Comments

@gjmooney
Copy link
Collaborator

gjmooney commented Oct 7, 2024

This issue to to track how we should handle sourceLayer stuff after a conversation with @martinRenou

QGIS organizes their vector tile layers like:

  • project layers
    • map layer
      • renderer
        • styles
          • style
            • symbols
              • symbol
                • symbol layer
                  • option
                    • color stuff

The type and sourceLayer from our schema that the style is being applied to is stored in the style part of their xml.

To bring our schema more in line with the QGIS implementation, I was thinking we could basically combine type, sourceLayer, and color entries from our schema into a style object, and have an array of those in the schema.

This would require a bit of refactoring, and since this is only relevant to one layer type it might not be worth the time expenditure at the moment, so I'm just opening this issue for now to keep it on our radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant