Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle only the latest waker #481

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: handle only the latest waker #481

merged 2 commits into from
Dec 13, 2024

Conversation

geofmureithi
Copy link
Owner

This attempts to resolve #477

@sjmiller609
Copy link

Thank you! I will set the polling rate back to 100ms, then use this version on my server. I'll report back once I have the information.

@sjmiller609
Copy link

sjmiller609 commented Dec 12, 2024

Started the server with the new version at 1:08 ET. Checking on it at 1:37 ET, CPU looks flat so far.

image

Zooming in on that, yes it looks flat.

image

CPU profile look good: no single function takes up a majority of the CPU load, and add_waker is not seen.

image

I think it works!

EDIT: I did not update the polling rate to 100ms, it's still at 1 second. I think it works, just FYI.

@geofmureithi geofmureithi merged commit e631465 into main Dec 13, 2024
4 checks passed
@geofmureithi geofmureithi deleted the fix/add-waker branch December 13, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High CPU use on add_waker
2 participants