-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online examples not working with HTTPS #359
Comments
thats a critcal one. But im wondering myself, how did you achieve to open the gh-pages with https? Maybe your browser redirected you to the https one? If so, we will have to look into that.. |
Even worse: a result of a search engine pointed to the HTTPS version of the gh-pages site. You are right, if you're following the links in the README everything is fine because it is HTTP. But we can't rely on this IMHO, especially when search engines offer the HTTPS version. Do you have time to care about this @weskamm ? |
yes i could spent some time on this. If you find more external resources causing the issue, please report them here |
work is ongoing, but cannot continue till friday... |
👍 |
fixed all the resources for the gh-pages, reviewed by @marcjansen , already online. |
This is again an issue since the online examples have been updated by the GeoExt 2.1.0 examples. I had a quick look at this. It seems that the ExtJS-resources loaded by this script, which needs to be adapted. But it seems that the adaptions for other resources (commits 7f16a9e, ff16e3f, aa2f354 and ead6943) are overwritten by the 2.1.0 release since the commits have only been pushed to the gh-pages branch. |
It was very bad of us to only commit to the gh-pages branch! So sorry for the confusion this has caused, @chrismayer. |
I tried to catch all HTTP calls which could be replaced by HTTPS. If you still discover any problems please report here. We should definitely port this patch to the master branch. |
👍 |
Thanks @chrismayer! i checked the examples and found 2 remaining problems: https://geoext.github.io/geoext2/examples/geocoder/geocoder.html https://geoext.github.io/geoext2/examples/popup/popup.html |
Thanks for cross-checking @weskamm!
Fixed in ea0347f
As suggested I fixed this by showing an appropriate BBOX (see #371 for the solution). I opened up an issue for the backport of the fixes regarding this issue to the master branch (#372). So this can be closed now. |
The online examples under https://geoext.github.io/geoext2/ do not work because ExtJS and OpenLayers are included with HTTP which is blocked by the browsers due to 'Mixed Content'.
The text was updated successfully, but these errors were encountered: