Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online examples not working with HTTPS #359

Closed
chrismayer opened this issue May 19, 2015 · 12 comments
Closed

Online examples not working with HTTPS #359

chrismayer opened this issue May 19, 2015 · 12 comments

Comments

@chrismayer
Copy link
Contributor

The online examples under https://geoext.github.io/geoext2/ do not work because ExtJS and OpenLayers are included with HTTP which is blocked by the browsers due to 'Mixed Content'.

@weskamm
Copy link
Member

weskamm commented May 19, 2015

thats a critcal one.

But im wondering myself, how did you achieve to open the gh-pages with https?
The links from the projects readme are just http, and following them works fine.

Maybe your browser redirected you to the https one? If so, we will have to look into that..

@chrismayer
Copy link
Contributor Author

Even worse: a result of a search engine pointed to the HTTPS version of the gh-pages site.

You are right, if you're following the links in the README everything is fine because it is HTTP. But we can't rely on this IMHO, especially when search engines offer the HTTPS version.

Do you have time to care about this @weskamm ?

@weskamm
Copy link
Member

weskamm commented May 19, 2015

yes i could spent some time on this.
the real solution would be to use https for every resource, but some of them are not in our hands / control.
I just had a quick look, the sencha cdn is also available on https, openlayers is hosted on our gh-pages so no problem there, ows.terrestris would need a fixup and there may be other resources i'm missing.

If you find more external resources causing the issue, please report them here

@weskamm
Copy link
Member

weskamm commented May 19, 2015

work is ongoing, but cannot continue till friday...

@marcjansen
Copy link
Member

👍

@weskamm
Copy link
Member

weskamm commented May 28, 2015

fixed all the resources for the gh-pages, reviewed by @marcjansen , already online.
Fixing the examples in the lib needs a little more effort, as they differ to much in order to apply a patch

@weskamm weskamm closed this as completed May 28, 2015
@chrismayer chrismayer reopened this Nov 25, 2015
@chrismayer
Copy link
Contributor Author

This is again an issue since the online examples have been updated by the GeoExt 2.1.0 examples.

I had a quick look at this. It seems that the ExtJS-resources loaded by this script, which needs to be adapted. But it seems that the adaptions for other resources (commits 7f16a9e, ff16e3f, aa2f354 and ead6943) are overwritten by the 2.1.0 release since the commits have only been pushed to the gh-pages branch.

@marcjansen
Copy link
Member

It was very bad of us to only commit to the gh-pages branch! So sorry for the confusion this has caused, @chrismayer.

@chrismayer
Copy link
Contributor Author

I tried to catch all HTTP calls which could be replaced by HTTPS. If you still discover any problems please report here.

We should definitely port this patch to the master branch.

@marcjansen
Copy link
Member

👍

@weskamm
Copy link
Member

weskamm commented Nov 26, 2015

Thanks @chrismayer! i checked the examples and found 2 remaining problems:

https://geoext.github.io/geoext2/examples/geocoder/geocoder.html
uses nominatim over http. A quick test shows that it works with https, so adjusting the url should be enough.

https://geoext.github.io/geoext2/examples/popup/popup.html
has problems with the bbox, as the map shows pink tiles on the first zoomlevel. I know this is not related to this discussion, but i think adjusting / lowering the maxextent should fix this. I currently have no time to fix the service itself, which should be the way to go...

@chrismayer
Copy link
Contributor Author

Thanks for cross-checking @weskamm!

https://geoext.github.io/geoext2/examples/geocoder/geocoder.html
uses nominatim over http. A quick test shows that it works with https, so adjusting the url should be enough.

Fixed in ea0347f

https://geoext.github.io/geoext2/examples/popup/popup.html
has problems with the bbox, as the map shows pink tiles on the first zoomlevel. I know this is not related to this discussion, but i think adjusting / lowering the maxextent should fix this. I currently have no time to fix the service itself, which should be the way to go...

As suggested I fixed this by showing an appropriate BBOX (see #371 for the solution).

I opened up an issue for the backport of the fixes regarding this issue to the master branch (#372).

So this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants