Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Add Pause Countdown #1765

Open
ShineUA opened this issue Apr 9, 2024 · 18 comments
Open

Add Pause Countdown #1765

ShineUA opened this issue Apr 9, 2024 · 18 comments

Comments

@ShineUA
Copy link

ShineUA commented Apr 9, 2024

Your mod link

https://github.com/ShineUA/pause-countdown-mod-geode/releases/download/v1.1.4/shineua.pause_countdown.geode

Your mod source code

https://github.com/ShineUA/pause-countdown-mod-geode/tree/v1.1.4/

Your mod description

This mod adds countdown on level resume.

Copy link

github-actions bot commented Apr 9, 2024

Waiting for staff to comment "!accept" to accept the entry.

Info:

  • Mod ID: shineua.pause_countdown
  • Version: 1.1.2
  • Targeting GD: {'win': '2.204', 'android': '2.205'}
  • Actual platforms: ['windows', 'android32', 'android64']
  • Targeting Geode: 2.0.0-beta.23

@camila314
Copy link
Member

add mac to the targets and i can accept it

@RayDeeUx
Copy link

wait there's a different conflict with GDMO that hasnt been fixed i think

not sure what the progress is on that

Copy link

Waiting for staff to comment "!accept" to accept the entry.

Info:

  • Mod ID: shineua.pause_countdown
  • Version: 1.1.3
  • Targeting GD: {'win': '2.204', 'android': '2.205', 'mac': '2.200'}
  • Actual platforms: ['macos', 'windows', 'android32', 'android64']
  • Targeting Geode: 2.0.0-beta.23

@ShineUA
Copy link
Author

ShineUA commented Apr 12, 2024

add mac to the targets and i can accept it

added

Copy link

Waiting for staff to comment "!accept" to accept the entry.

Info:

  • Mod ID: shineua.pause_countdown
  • Version: 1.1.4
  • Targeting GD: {'win': '2.204', 'android': '2.205', 'mac': '2.200'}
  • Actual platforms: ['macos', 'windows', 'android32', 'android64']
  • Targeting Geode: 2.0.0-beta.24

@Cvolton
Copy link
Member

Cvolton commented Apr 16, 2024

1st jump with space after unpause doesnt do anything if custom keybinds is installed

otherwise looks fine but it would be nice to see this resolved

@ShineUA
Copy link
Author

ShineUA commented Apr 18, 2024

1st jump with space after unpause doesnt do anything if custom keybinds is installed

otherwise looks fine but it would be nice to see this resolved

On mac?

@ShineUA
Copy link
Author

ShineUA commented Apr 18, 2024

Because I don't have this problem on Windows

@ShineUA
Copy link
Author

ShineUA commented Apr 18, 2024

You just need to click after countdown disappears

@Cvolton
Copy link
Member

Cvolton commented Apr 18, 2024

Windows version of the game, it only happens with custom keybinds mod installed and enabled

@Cvolton
Copy link
Member

Cvolton commented Apr 18, 2024

Should probably be noted that I used the spacebar for both u pausing and jumping while testing

@Fleeym
Copy link

Fleeym commented Apr 18, 2024

I get this with only Custom Keybinds installed, might not be because of this mod

@ShineUA
Copy link
Author

ShineUA commented Apr 18, 2024

Well, I don't really know what the problem with custom keybinds but my code only does this to prevent custom keybinds from executing functions on keys:

#ifdef GEODE_IS_WINDOWS

#include <Geode/modify/CCKeyboardDispatcher.hpp>
class $modify(CCKeyboardDispatcher) {
	static void onModify(auto& self) {
		self.setHookPriority("CCKeyboardDispatcher::dispatchKeyboardMSG", -69420);
	}

	bool dispatchKeyboardMSG(enumKeyCodes key, bool down, bool p2) {
		if(isResume) {
			return false;
		}
		return CCKeyboardDispatcher::dispatchKeyboardMSG(key, down, p2);
	}
};

#endif

@ShineUA
Copy link
Author

ShineUA commented Apr 18, 2024

I see the delay but I don't know how to fix this

@ShineUA
Copy link
Author

ShineUA commented Apr 18, 2024

Sometimes it works perfrectly

@ShineUA
Copy link
Author

ShineUA commented Apr 18, 2024

The only fix I found is just to change keybind.

@Fleeym
Copy link

Fleeym commented Apr 18, 2024

Bug happens because P1 Jump (bound to space) eats up all other events that use that key, even if pause menu is opened

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants