Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Add Recent Tab Challenge #1655

Open
npstauff opened this issue Mar 28, 2024 · 11 comments
Open

Add Recent Tab Challenge #1655

npstauff opened this issue Mar 28, 2024 · 11 comments

Comments

@npstauff
Copy link

Your mod link

https://github.com/npstauff/Recent-Tab-Challenge/releases/download/initial/npstauff.hundred-lives.geode

Your mod source code

https://github.com/npstauff/Recent-Tab-Challenge

Your mod description

See how many recent tab levels you can beat with a set number of lives, skips, and practice runs. The levels are randomly selected, and you keep going through them until you run out of lives.

Copy link

Waiting for staff to comment "!accept" to accept the entry.

Info:

  • Mod ID: npstauff.hundred-lives
  • Version: 1.0.0
  • Targeting GD: 2.204
  • Actual platforms: ['windows']
  • Targeting Geode: 2.0.0-beta.22

@npstauff npstauff changed the title Recent Tab Challenge Add Recent Tab Challenge Mar 28, 2024
Copy link

Waiting for staff to comment "!accept" to accept the entry.

Info:

  • Mod ID: npstauff.hundred-lives
  • Version: 1.0.0
  • Targeting GD: 2.204
  • Actual platforms: ['windows']
  • Targeting Geode: 2.0.0-beta.22

@RayDeeUx
Copy link

Within ten minutes of using this mod, here are some issues i found:
a mem crash

creator layer issues
creator layer issues

and whatever this is
and whatever this is

@RayDeeUx
Copy link

given the number of issues i found in the process of trying to reproduce the third screenshot, i have given up entirely

please resolve these issues on your own time

oh, one last thing: add @geode-sdk's Node IDs mod as a dependency in your mod.json as well!

@npstauff
Copy link
Author

damn i must be microsoft with the amount of bugs im producing, sorry for making you go through ill work on fixing them

@RayDeeUx
Copy link

conflicts with globed, finally found it
image
pinging @dankmeme01 as well

@dankmeme01
Copy link
Member

multiple issues that are blocking the accepting of this mod:

  1. First attempt of using the mod ended up in a crash when trying to open the 1st level (crashlog 1, crashlog 2), seems to be somewhat reproducible by spamming the play button and the Ok button from the popup, but not very consistent.
  2. As reported above, this will break Globed (and potentially other mods), since rather than properly exiting a level you just push a new scene with your layer, causing the PlayLayer to still exist in memory. This is also done in some other places, as whenever you call LivesLayer::scene you use pushScene instead of replaceScene, which keeps the previous scene in memory, therefore leading to memory leaks.
  3. Another potential crash cause is not clearing m_levelDownloadDelegate after the download has finished or the user has exited the layer - currently it doesn't crash because the layers are leaked anyway, but in the future this will probably be an issue.

Minor issues that won't lead to a rejection, but would still be nice to fix:

  1. It is impossible to exit the challenge layer by pressing the Esc key (you can override keyBackClicked in your layer to know when the button is pressed)
  2. The UI of the mod is a bit over the place, the challenge button looks different from others (you can use a geode-provided blank texture to have a nice green gradient on your button), the position of the back button is inconsistent with other places in the game (it should be a bit higher), the skip button looks a bit out of place

@mishpro-programm
Copy link

and whatever this is and whatever this is

This is a popup from my mod. It appears when you try to open a level, but the game already has a PlayLayer

@mishpro-programm
Copy link

So this means that this mod creates a PlayLayer. This popup also exists in Globed, as can be seen in your second screenshot.

@RayDeeUx
Copy link

let's goo, double the mod conflicts!

@npstauff
Copy link
Author

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants