-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Release v1.19.0 - #minor #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when clicking on play on the time slider the layer is updated and not removed/added which made a flickering effect.
WMS time enabled layer were not updated when changing their timestamp. This was also an issue on 3D. NOTE that for WMS all timestamps means that no TIME query param must be set.
Only detect the feature for the specific time.
PB-496: Added External WMS time config support
We could not identify timed layer with timestamp current or all on api3
…l-identify PB-537: Fix WMTS/WMS time enaled current/all timestamp identify
Use the date formatting based on the locale (en => MM/DD/YYYY, H:MM PM/AM, fr-CH => DD.MM.YYYY, HH:MM
PB-530: Added print date to the print API spec
The backend only support attachment up 10MB, above it returns a 413 error. Same for kml it only support kml up to 2MB. So do the validation up front and provide a nice message to the user.
At startup we never know the projection of the external layers, the projection is taken from the capabilities that needs to be loaded first. Therefore don't test projection upon creation and don't do any fallback. Also fixed an issue when a layer has only one timestamp, the time slider was displayed but the user could not change the timestamp.
hansmannj
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
Passing run #2273 ↗︎
Details:
Review all test suite changes for PR #859 ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link