New Release v1.16.0 - #minor #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The print scale on mobile was empty. This was due to the fact that we took the menu width in the computation for the scale. Now we don't take the menu width for the scale computation and we move the print center a bit down due to the header overlapping the map. Also did some renaming to make the code clearer
PB-437: Fix print scale
Issue : when clicking on the time slider bar, the years would not be saved in the layers when removing the time slider. Fix : we do it now
They border are now identical to the input border.
Now forms are only validated after user action. This provide a better user feedback especially when the form has several fields, the form is only validated when the user click on the action button.
Based on @pakb review
the need-validation class was useless therefore I removed it. Also removed a useless html div. Be consistent in the css class of all input fields.
PB-4564: Form validation
Issue : On all labels for layers, we mention that we're modifying the transparency, when we are currently modifying the opacity. fix : we reverse the value on the transparency slider, committing `1 - value` to the layer's opacity rather than the value. still TODO : ensure tests work.
Changed the slider data-cy from 'opacity' to 'transparency' for consistency. with the new margin, one test had problems where clicking in the middle (0.5 opacity) was so close to the original value (0.7 opacity) that it wouldn't register the click to be on another position on the slide.
…ncy-slider PB-481: bugfix apply transparency instead of opacity
This property was a duplicate of the id and not needed.
Some server don't support TIME=null parameter, which is anyway not conform. That was the case for the canton AG WMS server. Therefore don't add the TIME parameter if the layer has not time parameter.
PB-425: Implement external WMS external layer in 3D
The cesium style sheet overrides the global font. By changing the selector slightly we can give it more specifity and keep the original font
The cesium style sheet introduces a little bit of margin on the inputs which breaks the style of the time slider
PB-493: Fixed Time slider input cutoff on 3d Maps
Issue : When using the mapviewer on mobile, the time selector button had its text cut out. Fix : When on mobile view, we no longer enforce a width on the button, letting it fill the space to acomodate its content.
…-on-mobile PB-498: Fixed time selector css on mobile
Also load 50 features when selecting a rectangle on the map (instead of 10) The piece of code that was triggering the identification of feature was a store plugin, I thought it would make more sense to move all this to the feature store. Especially as I needed to write a second "get more feature" way of loading things. So now the store plugins only triggers a dispatch instead of loading the feature itself.
Also reworking the intercept of feature identification / feature detail, generating random coordinates from a feature template instead of having a very long (and repeating) fixture file. Adapting existing feature selection to use this new way of intercepting/fixtures Fixing a little bug in the randomIntBetween function found while testing (coordinates were not within the bracket when giving something else than 0 as the starting point...)
the selector for the zoom to extent Tippy tooltip was too eager and was re-applying the same tooltip over and over if more than one zoomToExtent button was present at a given time. Adding a component counter to give each component instance a unique ID (and applying Tippy only on this unique ID)
place 10/50 feature limits into config.js and use these new variables in tests (so they adapt to changes) add back "remove selected features" when clicking on a map location without no features
…button PB-368 : add "load more features" button in feature list
When the menu appears on desktop, the time slider has to move to the right
Issue : When opening the topic change popover, the images would not show anymore. This was due to the relative link in the css being incorrect. Fix : We change the relative link to reach the correct location. Using an absolute link rather than a relative link link correction
Passing run #2128 ↗︎
Details:
Review all test suite changes for PR #839 ↗︎ |
|||||||||||||||
pakb
approved these changes
May 14, 2024
As it was placing coordinate all around the LV95 extent, tests could get really flaky when wanting to show a tooltip (it was sometimes at the edge of the viewport, making it hidden)
…mizer PB-368 : fix e2e test feature coordinate randomizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link