PB-1080: show both warning and error feedback #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1080-show-warnings-and-errors-simultaneously
|
| Run status |
|
| Run duration | 05m 03s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
212
|
| View all changes introduced in this branch ↗︎ | |
pakb
reviewed
Nov 4, 2024
ltkum
force-pushed
the
fix-PB-1080-show-warnings-and-errors-simultaneously
branch
from
f258e95
to
f00440c
Compare
pakb
reviewed
Nov 11, 2024
ltkum
force-pushed
the
fix-PB-1080-show-warnings-and-errors-simultaneously
branch
3 times, most recently
from
8d1c613
to
6a49d74
Compare
pakb
reviewed
Nov 15, 2024
ltkum
force-pushed
the
fix-PB-1080-show-warnings-and-errors-simultaneously
branch
from
da17ae9
to
fdc38b4
Compare
|
do you have a good example that creates more than one warning/errors? |
usually what I do is : |
ltkum
force-pushed
the
fix-PB-1080-show-warnings-and-errors-simultaneously
branch
3 times, most recently
from
049bd6f
to
d01c99b
Compare
pakb
approved these changes
Nov 20, 2024
ismailsunni
approved these changes
Nov 20, 2024
- Issue : When we have both an error feedback and a warning feedback, they would be displayed one atop each other rather than in a column. - Fix : We create a small component to hold both the errors and warning feedback.
- added a counter to the feedbacks messages, telling the user how many errors / warnings there are - removed useless logs
ltkum
force-pushed
the
fix-PB-1080-show-warnings-and-errors-simultaneously
branch
from
d01c99b
to
971f431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link