Skip to content

Commit

Permalink
app-doc/geeknote: URI replace to my fork - previous repo is abandoned
Browse files Browse the repository at this point in the history 
Signed-off-by: Vitaly Zdanevich <[email protected]>
  • Loading branch information
@vitaly-zdanevich
vitaly-zdanevich committed Apr 24, 2024
1 parent fdd93b7 commit bebb60e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app-doc/geeknote/geeknote-9999.ebuild
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ DISTUTILS_USE_PEP517=setuptools

inherit bash-completion-r1 distutils-r1 git-r3

DESCRIPTION="Evernote CLI: CRUD for notes in cloud"
DESCRIPTION="Evernote CLI: CRUD for notes in cloud, in markdown"
HOMEPAGE="https://github.com/Evernote/evernote-sdk-python3"
EGIT_REPO_URI="https://github.com/jeffkowalski/geeknote"
EGIT_REPO_URI="https://github.com/vitaly-zdanevich/geeknote"

LICENSE="GPL-3"
SLOT="0"
Expand Down

12 comments on commit bebb60e

@antecrescent
Copy link
Contributor

@antecrescent antecrescent commented on bebb60e Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update metadata.xml.

Also you created this commit four minutes after replacing evernote3 with evernote2 upstream (vitaly-zdanevich/geeknote@b6e2849).
Later, you restrict tests for this ebuild but it seems that you haven't setup tests for your fork[1] nor do the original upstream tests seem to work for you[2].
Instead of forking and updating this package's sources prematurely, you could have also patched the original source in the ebuild (and maybe open a PR upstream so that more people benefit from your improvements).

Please correct me, if my assumptions are wrong. These changes just appear very rushed to me.

open issue at the time of writing:
[1] vitaly-zdanevich/geeknote#1
[2] jeffkowalski/geeknote#140

@vitaly-zdanevich
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, metadata.xml updated 378987b

@vitaly-zdanevich
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no automated tests now :(

But after hours of investigation I found how to fix the Geeknote - and I did it, I did manual test - I can see notes content in my terminal. I checked it on two computers.

and maybe open a PR upstream so that more people benefit from your improvements

Nobody response on the original repo :(
For example this PR is open in 2023 jeffkowalski/geeknote#139

@vitaly-zdanevich
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a message about my fork - so author will see it jeffkowalski/geeknote#142

@stkw0
Copy link
Contributor

@stkw0 stkw0 commented on bebb60e Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What fixes the change from the official evernote3 to the unofficial evernote2?
Adding python-oauth2 and evernote2 is problematic, given that the first one is officially deprecated (in favour of oauthlib) and the second is abandoned. An easy solution would be to revert vitaly-zdanevich/geeknote@b6e2849 and revert the commits adding python-oauth2 and evernote2.

@vitaly-zdanevich
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What fixes the change from the official evernote3 to the unofficial evernote2?

Evernote/evernote-sdk-python@master...JackonYang:evernote2:master

the first one is officially deprecated (in favour of oauthlib)

Is it a drop-in replacement?

An easy solution would be to revert

So Geeknote will stop work with official evernote3 Python SDK.

@stkw0
Copy link
Contributor

@stkw0 stkw0 commented on bebb60e Apr 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What fixes the change from the official evernote3 to the unofficial evernote2?

Evernote/[email protected]:evernote2:master

The evernote3 upstream is https://github.com/Evernote/evernote-sdk-python3, not the one you used to show that diff. Please check if geeknote works with evernote3.

Is it a drop-in replacement?

I don't know.

@vitaly-zdanevich
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if geeknote works with evernote3

It already was with evernote-sdk-python-3 - failing on every operation, I filled an issue for them https://github.com/Evernote/evernote-sdk-python3/issues/41

@stkw0
Copy link
Contributor

@stkw0 stkw0 commented on bebb60e Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thank you.

@vitaly-zdanevich
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oauthlib works with geeknote without changing of anything! 1810aef

@stkw0
Copy link
Contributor

@stkw0 stkw0 commented on bebb60e Apr 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! Then tomorrow I will proceed to masking python-oauth2 for removal if you agree

@antecrescent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stkw0 and @vitaly-zdanevich for figuring this out :)
Also sorry Vitaly about the whole paragraph about these changes being rushed. Who am I to judge, if I didn't really test it and if it works just fine.

Please sign in to comment.