Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config cleanup #3

Open
genmeblog opened this issue Apr 9, 2019 · 1 comment
Open

config cleanup #3

genmeblog opened this issue Apr 9, 2019 · 1 comment

Comments

@genmeblog
Copy link
Contributor

genmeblog commented Apr 9, 2019

  1. atom for global configuration
  2. register-config function
  3. move all configs to implementations and review
  4. multiple inheritance
  5. remove config namespace
@joinr
Copy link

joinr commented Jun 26, 2019

cljplot.config/configuration-functions maybe should be tied into the current method table....

(-> cljplot.common/render-graph bean :methodTable keys)
Or whatever is tied to configuration. This greatly facilitates runtime spec validation, and extensibility, since you can hook validation into the multimethod implementations directly.

I'm uncertain about the values in configuration-functions, I'm guessing they're supposed to define expected argument arities and types that are coming through the multimethod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants