Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some inferred annotations have the incorrect aspect #1096

Open
ValWood opened this issue May 28, 2019 · 3 comments
Open

Some inferred annotations have the incorrect aspect #1096

ValWood opened this issue May 28, 2019 · 3 comments

Comments

@ValWood
Copy link
Contributor

ValWood commented May 28, 2019

from
#767

here for example:

PomBase SPAC14C4.08 mug5 contributes_to GO:0032118 PMID:25736293 IC GO:0106006 F dynactin complex subunit Mug5 protein taxon:4896 20170718 GOC-OWL part_of(GO:0032118)

The term annotated is
GO:0032118
GO:0032118 is A BIOLOGICAL PROCESS TERM
horsetail-astral microtubule organization (GO:0032118)

The aspect reported in the GAF file is F.

@ValWood
Copy link
Contributor Author

ValWood commented May 28, 2019

@cmungall commented

Yes, owltools

incorrect aspect

The incorrect aspect issue was reported here: owlcollab/owltools#237

The ticket was not closed, but I believed it was fixed by HyeongSik with this PR, which was merged: owlcollab/owltools#239

However, it seems that he only implemented this for the basic annotation propagator, not for the annotation deepening.

Action: I can fix this, how high a priority is this for you?

Ultimately this code will be rewritten

@pgaudet
Copy link
Contributor

pgaudet commented May 29, 2019

If annotations are being exported, this seems high priority.

@ValWood
Copy link
Contributor Author

ValWood commented May 29, 2019

It is a bug, but it has been around for a long time and doesn't seem to trip anyone up (which is strange). Probably not a lot of code checks that the aspect matches the GO term...

It is a bit shoddy though.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants