Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated/removed InnoDB variables - innodb_large_prefix, innodb_file_format #454

Open
eRadical opened this issue Jun 22, 2021 · 5 comments
Labels

Comments

@eRadical
Copy link
Contributor

There are a lot of deprecated variables in MySQL/InnoDB/MariaDB. Example: MDEV-23397.

Filling ticket to compile a full list of deprecated variables but used by this role.
Then I'll follow up w/ a pull req.

@eRadical
Copy link
Contributor Author

These are my findings:

  • expire_logs_days - is deprecated in MySQL in favor of binlog_expire_logs_seconds which defaults to 30 days, in MariaDB they're related as changes in one adjusts the other one - I think we should keep binlog_expire_logs_seconds and compute from mysql_expire_logs_days
  • symbolic-links - is deprecated in MySQL, not deprecated in MariaDB - I think we ought to remove it
  • innodb_large_prefix - deprecated in both - we ought to remove it completely
  • innodb_file_format - deprecated in both - we ought to remove it completely

Also I thin pid-file should also be deprecated as it can be absent when SystemD is used.

@geerlingguy thoughts?

@geerlingguy
Copy link
Owner

I'm okay with all those changes—the only one I think could be weird is symbolic-links. Not sure if people use it much (I don't... but I can't speak for all users of the role).

@stale
Copy link

stale bot commented Sep 26, 2021

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@stale stale bot added the stale label Sep 26, 2021
@eRadical
Copy link
Contributor Author

Still here! Not stale!

@stale
Copy link

stale bot commented Sep 30, 2021

This issue is no longer marked for closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants