New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for UTF8 Characters in URL and domains without http:// #8

Open

nourbakhsh opened this issue Mar 9, 2016 · 0 comments

nourbakhsh commented Mar 9, 2016

Hi,
thanks for your work and this awesome tool :)
But it doesn't work with URLs with UTF8 Characters in them like:
https://http2pic.haschek.at/api.php?url=http://www.dw.com/fa-ir/%D8%A2%D9%85%D9%88%D8%B2%D8%B4-%D8%A2%D9%84%D9%85%D8%A7%D9%86%DB%8C/s-2768
also not with rawurlencode:
https://http2pic.haschek.at/api.php?url=http%3A%2F%2Fwww.dw.com%2Ffa-ir%2F%D8%A2%D9%85%D9%88%D8%B2%D8%B4-%D8%A2%D9%84%D9%85%D8%A7%D9%86%DB%8C%2Fs-2768
This feature would be really nice.

And i would also suggest to support URLs without http:// or www. like
https://http2pic.haschek.at/api.php?url=google.com
https://http2pic.haschek.at/api.php?url=www.google.com

I think both of them could be solved by an another implementation of function isURLValid. For International Domains the PHP Function: http://ch1.php.net/manual/en/function.idn-to-ascii.php could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment