-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Schemes in general. #40
Comments
A. both the translucency and colours of the current line can be set by the theme, so I guess its up to the theme makers how they want to show it. B. not sure exactly what you mean by "frame" but it what I would call the frame doesn't change colour with "invert colours" for me. |
A. My bad. I found out that the current line colors were over-ridden by filetypes.common. Commenting them out fixed this. B. By 'frame' I really meant the line numbers on the left hand side. Colours will change when in 'invert syntax highlighting colours' is on. (linux lubuntu 18.04, Geany 1.32). |
Ok, what you are calling "frame" are the "margins". The "frame" is a GTK thing around the editing widget and is set by GTK themes. "Margins" are part of the editing widget and are set by "colour schemes" as in this repo. (Maybe "themes" is a bad name for the repo, but thats what it was initially called and thats what its stayed). The editing widget is not affected by GTK themes since its unrealistic to expect global desktop themes to set values for things like "line_numbers" or "folding" or "C program types" etc, and so the Geany "colour schemes" fill that gap. But it appears complicated.
Each setting can be set to a value or a named style.
The values of the named styles are set by the "colour schemes" if they want to change the default. So if a setting in For example translucency values are set to values in This way colour schemes do not have to set values for each syntactic element for each programming language, just a common set of named styles and the |
I use dark mode Ubuntu and i can't read the first line in Geany's "Messages" pane. When this pane displays search results, this first line is dark blue on black background and there is no contrast at all. Related : #2293 |
@JLuc Geany themes/colour schemes only apply to the editing widget, not other UI elements. |
Great : editing geany.css could fix it cf geany/geany#2644 (comment) |
A. None of the dark schemes (bright text) view well with the current editing line which has a bright background highlighter. Am I missing something ?
B. The editor frame doesn't change color (as explained in another closed issue) because it is part of the GTK themes. But it does change if you ask Geany to invert ALL colors. In such a case, should not dark theme developers design their themes for inverted mode instead of normal mode?
The text was updated successfully, but these errors were encountered: