From 9f95163f7f2f3b9866f792808c4e2e35eaadd16e Mon Sep 17 00:00:00 2001 From: Steve Peters Date: Wed, 8 Nov 2023 21:06:36 -0800 Subject: [PATCH] Revert "Add missing visibility declarations (#548)" This reverts commit a52a7d2649317a0d8f47f82999e94846694105b9. Signed-off-by: Steve Peters --- profiler/src/RemoteryProfilerImpl.cc | 2 -- src/SignalHandler.cc | 2 +- testing/include/gz/common/testing/CMakeTestPaths.hh | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/profiler/src/RemoteryProfilerImpl.cc b/profiler/src/RemoteryProfilerImpl.cc index 7f1954a43..b233adfef 100644 --- a/profiler/src/RemoteryProfilerImpl.cc +++ b/profiler/src/RemoteryProfilerImpl.cc @@ -16,7 +16,6 @@ */ #include "gz/common/config.hh" -#include #include "RemoteryProfilerImpl.hh" #include "gz/common/Console.hh" @@ -25,7 +24,6 @@ using namespace gz; using namespace common; -GZ_COMMON_PROFILER_VISIBLE std::string rmtErrorToString(rmtError error) { switch (error) { case RMT_ERROR_NONE: diff --git a/src/SignalHandler.cc b/src/SignalHandler.cc index 07b6d054c..7ad81d815 100644 --- a/src/SignalHandler.cc +++ b/src/SignalHandler.cc @@ -31,7 +31,7 @@ using namespace gz; using namespace common; // A wrapper for the sigaction sa_handler. -GZ_COMMON_VISIBLE std::map> gOnSignalWrappers; +std::map> gOnSignalWrappers; std::mutex gWrapperMutex; ///////////////////////////////////////////////// diff --git a/testing/include/gz/common/testing/CMakeTestPaths.hh b/testing/include/gz/common/testing/CMakeTestPaths.hh index 6ca7de401..362ae2953 100644 --- a/testing/include/gz/common/testing/CMakeTestPaths.hh +++ b/testing/include/gz/common/testing/CMakeTestPaths.hh @@ -28,7 +28,7 @@ namespace gz::common::testing /// /// It is not intended that users will directly construct this, but rather /// utilize the TestPathFactory. -class GZ_COMMON_TESTING_VISIBLE CMakeTestPaths: public TestPaths +class CMakeTestPaths: public TestPaths { /// \brief Constructor from TestPaths public: using TestPaths::TestPaths;