Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some language keywords are not highlighted in VS Code #26

Open
twolfvb opened this issue May 18, 2021 · 6 comments
Open

Some language keywords are not highlighted in VS Code #26

twolfvb opened this issue May 18, 2021 · 6 comments
Labels
vscode VS Code Related
Milestone

Comments

@twolfvb
Copy link

twolfvb commented May 18, 2021

Just switching from CLion using GapStyle to VSCode (making an effort to cut costs). Same C/C++ codebase.

I've noticed that some of the stuff that was highlighted on CLion isn't highlighted here.

For instance, static_cast/const_cast/dynamic_cast

image

Also, RHS on VSCode, not sure why the & in line 22 is colored there and not in line 13 where I thjink they've been used the same way.

Would it make sense to compile a list of things that look different to then fix them, or would it be a low priority issue that might not get fixed?

Gary, thanks for you theme, I love it ♥

@gaplo917
Copy link
Owner

Hi @twolfvb , could you do me a favor to screen capture the Textmate scopes for me on your C/C++ projects.

Follow the description to Enable inspect TM Scope https://github.com/gaplo917/GapStyle/blob/master/vscode/vsc-extension-quickstart.md#get-up-and-running-straight-away

Examples

microsoft/vscode#94957

@twolfvb
Copy link
Author

twolfvb commented May 26, 2021

image
image

Does that work for you?

Best,

@gaplo917 gaplo917 added the vscode VS Code Related label Jun 13, 2021
@gaplo917 gaplo917 added this to the VS-2.0 milestone Jun 13, 2021
@luchian94
Copy link

@gaplo917 I would like to add that Angular support is also missing some essential highlight colors.

Here is the example screenshot, on the right is GapStyle for Intellij which works much better.
As you can see angular expressions/variables are just white.
Also Angular components/entities are the same color as HTML tags (while in intellij the colors are different)

image

I tried overriding some textmate scopes but it doesn't seem to work, for example using this configuration object inside textMateRules
{ "scope": "expression.ng", "settings": { "foreground": "#CF8823" } }

Here are some additional screens:
image
image

@gaplo917
Copy link
Owner

@luchian94 could you help to try

{ "scope": "expression.ng variable.other.object.ts", "settings": { "foreground": "#CF8823" } }

@luchian94
Copy link

@gaplo917 just tried it and it doesn't seem to work. The only way I got variables colored is by using these scopes:
'variable.other.readwrite.alias.ts' and 'variable.other.readwrite.ts' but it's still not so good

image

@gaplo917
Copy link
Owner

@luchian94 I am adding support to Angular, stay tune!

Before
image

After
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode VS Code Related
Projects
None yet
Development

No branches or pull requests

3 participants