Remove compatibility mode from the GAP build system for old GAP packages (all currently distributed packages do not need it anymore) #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: build system
release notes: use title
fingolfin
force-pushed
the
mh/no-compat
branch
from
23faa20
to
929d82c
Compare
|
Any thoughts on this one, @ChrisJefferson ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I grepped through all distributed packages for uses of
bin/gap.sh; most packages use it only as a fallback for old GAP versions (which of course is fine). Other packages using it:anupquses it in itstst/make_anupqegperl script. This is for internal use and if we (= the anupq maintainers, which is essentially me these days, I think) ever want to run it again, we'll adjust it (and we'll have to make more adjustments anyway)float, see buildsys: locate GAP executable using info from sysinfo.gap gap-packages/float#89francyuses it in aDockerfile, but that doesn't seem relevant (but of course I still submitted Don't use bin/gap.sh gap-packages/francy#108)jupyterkernelmentions in its README... Don't use bin/gap.sh gap-packages/JupyterKernel#130SCSCP, see Don't use bin/gap.sh gap-packages/scscp#45ZeroMQInterfaceuses it in itszgapscript, but that is broken anywayIMHO we could just merge then and then inspect if how it affects the package distro, and if necessary, update any affected packages...
Resolves #4996