Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable by default (and eventually get rid) of "compatibility mode" in our build system #4996

Closed
fingolfin opened this issue Aug 17, 2022 · 4 comments · Fixed by #5522
Closed
Assignees

Comments

@fingolfin
Copy link
Member

Our build system has a "compatibility mode" which is on by default, and exists to help packages with kernel extensions that expects certain things to be arranged exactly as they were in older GAP versions (before the new build system in 4.9).

I'd like to switch the default to "off" and at some point remove this mode. But that requires active testing for it and probably adjustments to a few packages. And possibly also to the GAP build system -- it may be that a few things that I back then only enabled in "compatibility mode" because I thought we don't need it anymore actually should be retained.

I plan to work on this, but I wouldn't mind help, so if anyone is interested... :-)

@fingolfin fingolfin added this to the GAP 4.13.0 milestone Aug 17, 2022
@fingolfin fingolfin self-assigned this Aug 17, 2022
@ChrisJefferson
Copy link
Contributor

How does one switch it off? I can check if anything terrible happens on windows

@fingolfin
Copy link
Member Author

There is a configure switch, ask ./configure --help. As it is, I am not even sure it works at all; and it may already break stuff on Linux

@fingolfin
Copy link
Member Author

fingolfin commented Oct 7, 2022

Some things compat mode creates:

  1. bin/gap.sh
    • this still used by a ~13 packages, and also by GAP itself.
  2. symlink sysinfo.gap-default64 -> sysinfo.gap
  3. a bunch of symlinks in bin/$GAPARCH:
    • config.h -> ../../build/config.h`
    • gac -> ../../gac`
    • gap -> ../../gap`
    • src -> ${srcdir}/src

Since a lot uses bin/gap.sh, I'd leave it in for now. But the other kinks are prime candidates for removal. I've done this now in PR #5101

@fingolfin
Copy link
Member Author

fingolfin commented Dec 15, 2022

Packages which still seem to be using gap.sh unconditionally:

So we are looking pretty good in this regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants