Fix out-of-bounds read & write #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc warns: selfile.c:1253:24: warning: "strncat" specified bound depends on the length of the source argument [-Wstringop-overflow=] 1253 | (void) strncat(SFcurrentPath, str, len - 1); The third argument ought to be the size of the _destination_, not the _source_. You need snprintf (or a contrived mix of min()+max()) if you want to also restrict the source length. Also, `len - 1` can underflow if the string length for some reason is 0, catch that case as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc warns:
The third argument ought to be the size of the destination, not the source. You need snprintf (or a contrived mix of min()+max()) if you want to also restrict the source length.
Also,
len - 1can underflow if the string length for some reason is 0, catch that case as well.Run through the compiler only; not runtime-tested.