Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using EvalString in IO_Unpickle #7

Open
ChrisJefferson opened this issue Mar 27, 2014 · 1 comment
Open

Avoid using EvalString in IO_Unpickle #7

ChrisJefferson opened this issue Mar 27, 2014 · 1 comment

Comments

@ChrisJefferson
Copy link
Member

IO_Unpickle using EvalString means that a malicious data file can perform arbitrary code execution. Part of me feels this is a bad thing, and it might be worth putting the work in to remove the evals. However GAP might already be such a leaky sieve that this ship has sailed!

Interested in opinions.

@fingolfin
Copy link
Member

I think we should indeed try to avoid using EvalString; not just for security reasons but also for general robustness and reproducibility reasons.

Of course overall, there are probably tons and tons of places in GAP that you could use for an exploit. But that shouldn't be an excuse for leaving unsafe code in... ;-). On the plus side, as long as you don't run GAP as a special privileged user, and don't expose it externally, I see little harm coming that way. Of course, if one wants to offer access to GAP via e.g. a webfront (similar to what Sage and polymake offer), this might be a bit different.

@fingolfin fingolfin changed the title Should IO_Unpickle use EvalString? Avoid using EvalString in IO_Unpickle Nov 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants