Check for malformed responses in getAccountInfo/getMultipleAccounts

[archseer]

GetObject could unmarshal into nil which would cause a panic when referring to out.Value.

This is unlikely since a node will typically return well formed responses but still worth fixing.

[archseer]

Most RPC calls also have issues: they return pointers which could be deserialized to nil.

For example

solana-go/rpc/getBalance.go

Lines 25 to 34 in 7de08b2

	// GetBalance returns the balance of the account of provided publicKey.
	func (cl *Client) GetBalance(
	ctx context.Context,
	// Pubkey of account to query. Required.
	publicKey solana.PublicKey,
	// Commitment requirement. Optional.
	commitment CommitmentType,
	) (out *GetBalanceResult, err error) {

could return GetBalanceResult rather than *GetBalanceResult?

[gagliardetto]

See #45

[gagliardetto]

Most RPC calls also have issues: they return pointers which could be deserialized to nil.

For example

solana-go/rpc/getBalance.go

Lines 25 to 34 in 7de08b2

	// GetBalance returns the balance of the account of provided publicKey.
	func (cl *Client) GetBalance(
	ctx context.Context,
	// Pubkey of account to query. Required.
	publicKey solana.PublicKey,
	// Commitment requirement. Optional.
	commitment CommitmentType,
	) (out *GetBalanceResult, err error) {

could return GetBalanceResult rather than *GetBalanceResult?

How would you know that you have a real GetBalanceResult an not just one that was null json? You can only if you use a *GetBalanceResult.

If the response deserializes to nil, that either follows the spec (e.g. getBlock: https://github.com/solana-labs/solana/blob/master/docs/src/developing/clients/jsonrpc-api.md#getblock ) or is an error on the RPC provider part.

I'll leave that to the library user for now to implement given they know best that RPC they are dealing with.