Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add support for heroku-buildpack-chrome-for-testing #36

Open
naoyanickf opened this issue Jun 25, 2024 · 2 comments
Open

Request: add support for heroku-buildpack-chrome-for-testing #36

naoyanickf opened this issue Jun 25, 2024 · 2 comments

Comments

@naoyanickf
Copy link

Latest version of jemalloc doesn't work with heroku-buildpack-chrome-for-testing

Please refer this thread

Chromedriver Segmentation fault when used with jemalloc buildpack
heroku/heroku-buildpack-chrome-for-testing#18

@gaffneyc
Copy link
Owner

What change do you think needs to be made to the buildpack to support the chrome-for-testing buildpack? Is this only an issue with the heroku-20 stack which was recently deprecated or are you also seeing it on heroku-22 and heroku-24?

A work around would be not to set the JEMALLOC_ENABLED environment variable and instead us jemalloc.sh to run only the processes you want using jemalloc.

@lucafrollo
Copy link

Hi. I tested the buildpack above with heroku-22 and I am getting the same errors we get in heroku-20.
We are getting intermittent errors launching Chrome via Puppeteer.

If we use the old deprecated heroku Chrome buildpack, then we do not get any errors in either heroku-20 or heroku-22.

The only visible difference (excluding the shims which I replicated with the new buildpack) I can see in the old buildpack code is at this line where the old buildpack does

unset LD_PRELOAD

I would not know how to do that though without forking the new buildpack.
We are already using jmalloc.sh but Chrome/Puppeteer are invoked within both our dynos so no workaround there.

It is an unfortunate situation as we cannot currently upgrade to heroku-24 because of this issue as the old buildpack is not supported there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants