Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GoodNews 1.x to 2.x not possible #102

Open
zahlenhexe opened this issue Mar 13, 2023 · 2 comments
Open

Upgrade GoodNews 1.x to 2.x not possible #102

zahlenhexe opened this issue Mar 13, 2023 · 2 comments
Assignees

Comments

@zahlenhexe
Copy link

After upgrading to MODX3/GoodNews2, the content of the contexts with GoodnewsContainers is not displayed.

In my opinion the problem is that the existing documents with the old DocumentType are not renamed during the installation of GoodNews 2.0.0-alpha2.

GoodNewsResourceContainer -> Bitego\GoodNews\Model\GoodNewsResourceContainer
GoodNewsResourceMailing -> Bitego\GoodNews\Model\GoodNewsResourceMailing

I did the renaming manually. Then the resource tree is displayed again.

@gadgetto
Copy link
Owner

Sorry, GoodNews 2.x currently has no upgrade path! It's already on my list. As GoodNews 2 is a complete rewrite (code base) and has a complete new file structure (composer based) running an upgrade on v1.x will be much more complicated then just renaming the classes.

But it's great that you did this step. Yes the class keys needs to be changed beside many other things.
It would be great if you could report any other problems you can find.

@gadgetto gadgetto changed the title Error upgrade to MODX3 class_key is not renamed Upgrade GoodNews 1.x to 2.x not possible Mar 13, 2023
@gadgetto gadgetto self-assigned this Mar 13, 2023
@zahlenhexe
Copy link
Author

zahlenhexe commented Mar 13, 2023

I did a few tests.
First the new subscribers were not added to the groups/categories.
But this is due to the parsing of the input/output modifiers. Its a bug in MODX3.

I'm using &defaultGroups and &defaultCategories.
The output of

[[!+fields_hidden:is=`1`:then=`
            [[!+grpcatfieldsets]]
        `:else=`

gives only 1 instead of parsed fields.

But you already know that 😎: MODX3 broken Output Filter/Modifiers. This error still exists in modx 3.0.3-pl.

Then after subscription the user was not redirected to the &submittedResourceId. But this is due to my &postHooks snippet.
because use of: $modx->mail->set(modMail::MAIL_BODY,$message);

This had to be reworked due to this post of @BobRay from the forum.

Now the Subscription works as expected.

Best regards

Iris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants