Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speed and performance of dk_prepare_schematic() #29

Closed
gacolitti opened this issue Dec 3, 2023 · 1 comment
Closed

Improve speed and performance of dk_prepare_schematic() #29

gacolitti opened this issue Dec 3, 2023 · 1 comment

Comments

@gacolitti
Copy link
Owner

Currently it takes about 0.5s to run dk_prepare_schematic() when all data is passed:

draft_group_id <- 80584
draft_group <- dk_get_draft_group(draft_group_id)
draft_group_info <- dk_get_draft_group_info(draft_group_id)
rules <- dk_get_game_type_rules(96)
draft_group$exp_fp <- runif(nrow(draft_group))
system.time(dk_prepare_schematic(draft_group_id = draft_group_id, rules = rules, draft_group = draft_group))

This means that to prepare all the draft groups for an entire NBA season (about 700) takes about 6 minutes.
@gacolitti
Copy link
Owner Author

Addressed in #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gacolitti